updates signature / documents for timeoutWith #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
chore-timeoutwith
branch
from
c0b78bc
to
3ea1b75
Compare
kwonoj
force-pushed
the
chore-timeoutwith
branch
from
3ea1b75
to
0c00ed0
Compare
kwonoj
force-pushed
the
chore-timeoutwith
branch
from
0c00ed0
to
cb2a618
Compare
|
LGTM, please rebase. |
- update signature to accept withObservable as ObservableInput, to align with internal implementation
kwonoj
force-pushed
the
chore-timeoutwith
branch
from
cb2a618
to
4013116
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates signature of
timeoutWithto acceptwithObservableasObservableInput, as internal implementation already able to support it via utilizingsubscribeToResult. In addition to those, updated migration document to list timeout operator split.Related issue (if exists):